Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve plugin build & release process #8

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from

Lowers top supported version

5d3fd2e
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Draft

Improve plugin build & release process #8

Lowers top supported version
5d3fd2e
Select commit
Loading
Failed to load commit list.
GitHub Actions / Qodana Community for JVM completed Dec 2, 2024 in 0s

617 new problems found by Qodana Community for JVM

Qodana Community for JVM

617 new problems were found

Inspection name Severity Problems
Wrong package statement 🔴 Failure 79
Unnecessary unicode escape sequence 🔶 Warning 248
Unused import 🔶 Warning 116
Nullability and data flow problems 🔶 Warning 18
Deprecated API usage 🔶 Warning 16
Unstable API Usage 🔶 Warning 14
Unchecked warning 🔶 Warning 10
Incorrect string capitalization 🔶 Warning 7
Unused assignment 🔶 Warning 6
Default annotation parameter value 🔶 Warning 5
Field can be local 🔶 Warning 5
@NotNull/@Nullable problems 🔶 Warning 4
'size() == 0' can be replaced with 'isEmpty()' 🔶 Warning 3
Redundant 'if' statement 🔶 Warning 3
Redundant local variable 🔶 Warning 2
C-style array declaration 🔶 Warning 1
Redundant 'Collection.addAll()' call 🔶 Warning 1
Constant values 🔶 Warning 1
Field may be 'final' 🔶 Warning 1
Loop variable not updated inside loop 🔶 Warning 1
Unnecessary 'null' check before method call 🔶 Warning 1
Redundant type cast 🔶 Warning 1
String concatenation in loop 🔶 Warning 1
Duplicate branches in 'switch' ◽️ Notice 66
Method can be extracted ◽️ Notice 4
Commented out code ◽️ Notice 1
Constant values ◽️ Notice 1
Non-strict inequality '>=' or '<=' can be replaced with '==' ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true
Contact Qodana team

Contact us at [email protected]

Details

This result was published with Qodana GitHub Action

Annotations

Check warning on line 38 in src/main/gen/lexer/_OgnlLexer.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

C-style array declaration 

Field `ZZ_LEXSTATE` has C-style array type declaration

Check warning on line 50 in src/main/java/com/intellij/struts2/dom/struts/action/ExceptionMappingResultResolveConverter.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Redundant 'Collection.addAll()' call 

'addAll()' call can be replaced with parametrized constructor call

Check notice on line 114 in src/main/java/com/intellij/struts2/graph/fileEditor/Struts2GraphComponent.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Commented out code 

Commented out code (23 lines)

Check warning on line 296 in src/main/gen/parser/OgnlParser.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Constant values 

Condition `p` is always `false` when reached

Check notice on line 639 in src/main/gen/parser/OgnlParser.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Constant values 

Value `r` is always 'true'

Check warning on line 110 in src/main/java/com/intellij/struts2/freemarker/Struts2GlobalVariableProvider.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Nullability and data flow problems 

Argument `action.getXmlTag()` might be null

Check warning on line 141 in src/main/java/com/intellij/struts2/facet/ui/FileSetConfigurationTab.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Nullability and data flow problems 

Method invocation `setEnabled` may produce `NullPointerException`

Check warning on line 96 in src/main/java/com/intellij/struts2/reference/web/StrutsConstantValueReference.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Nullability and data flow problems 

Expression `elementConverterPair.second .getErrorMessage(getValue(), ConvertContextFactory.createConvert...` might evaluate to null but is returned by the method declared as @NotNull

Check warning on line 203 in src/main/java/com/intellij/struts2/intentions/code/CreateValidationXmlIntention.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Nullability and data flow problems 

Argument `path` might be null

Check warning on line 52 in src/main/java/com/intellij/struts2/reference/ResultActionPropertyReferenceProvider.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Nullability and data flow problems 

Argument `result.getXmlTag()` might be null

Check warning on line 126 in src/main/java/com/intellij/struts2/spring/ExtendableClassConverterSpringContributor.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Nullability and data flow problems 

Method invocation `size` may produce `NullPointerException`

Check warning on line 44 in src/main/java/com/intellij/struts2/dom/struts/constant/ConstantValueConverterImpl.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Nullability and data flow problems 

Method invocation `getProject` may produce `NullPointerException`

Check warning on line 61 in src/main/java/com/intellij/struts2/reference/ResultActionPropertyReferenceProvider.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Nullability and data flow problems 

Result of 'max' is the same as the first argument making the call meaningless

Check warning on line 178 in src/main/java/com/intellij/struts2/dom/struts/impl/path/ActionPathResultContributor.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Nullability and data flow problems 

Argument `action.getXmlTag()` might be null

Check warning on line 156 in src/main/java/com/intellij/struts2/dom/validator/ValidatorManagerImpl.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Nullability and data flow problems 

Argument `clazz.getName()` might be null

Check warning on line 142 in src/main/java/com/intellij/struts2/facet/ui/FileSetConfigurationTab.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Nullability and data flow problems 

Method invocation `setEnabled` may produce `NullPointerException`

Check warning on line 136 in src/main/java/com/intellij/struts2/dom/struts/impl/path/ActionChainOrRedirectResultContributor.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Nullability and data flow problems 

Argument `action.getXmlTag()` might be null

Check warning on line 73 in src/main/java/com/intellij/struts2/gotosymbol/GoToActionSymbolProvider.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Nullability and data flow problems 

Argument `action.getXmlTag()` might be null

Check warning on line 167 in src/main/java/com/intellij/struts2/jsp/inspection/HardcodedActionUrlInspection.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Nullability and data flow problems 

Method invocation `getFirst` may produce `NullPointerException`

Check warning on line 83 in src/main/java/com/intellij/struts2/gotosymbol/GotoRelatedActionProvider.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Nullability and data flow problems 

Argument `resolve` might be null

Check warning on line 234 in src/main/java/com/intellij/struts2/facet/ui/FileSetConfigurationTab.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Nullability and data flow problems 

Method invocation `getContextComponent` may produce `NullPointerException`

Check warning on line 145 in src/main/java/com/intellij/struts2/graph/StrutsDataModel.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Nullability and data flow problems 

@Nullable method 'createGroupNodeRealizer' always returns a non-null value

Check warning on line 92 in src/main/java/com/intellij/struts2/annotators/StrutsConventionImplicitUsageProvider.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Nullability and data flow problems 

Argument `psiClass.getName()` might be null

Check warning on line 51 in src/main/java/com/intellij/struts2/dom/struts/action/Action.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Default annotation parameter value 

Redundant default parameter value assignment

Check warning on line 38 in src/main/java/com/intellij/struts2/dom/struts/Bean.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Default annotation parameter value 

Redundant default parameter value assignment
View more details on GitHub Actions