-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WW-4520 - Add prefix for CSS classes. #44
base: master
Are you sure you want to change the base?
Conversation
Struts-JDK7-pull-request #44 FAILURE |
Christoph Nenning on [email protected] replies: have you guys seen this jira and PR? What do you think about the compatibility issues? For me it would be OK to change it in 2.5, but it already scares me to https://issues.apache.org/jira/browse/WW-4520 regards, This Email was scanned by Sophos Anti Virus |
Lukasz Lenart on [email protected] replies: 2015-07-02 9:10 GMT+02:00 Christoph Nenning [email protected]: |
Hm... I wonder how hard it will be to make this configurable so we can keep backward compatibility and allow enable a custom prefix on demand. |
Making this configurable would be cool. But when looking at changed files, and all those different file types, i fear it would be hard. |
@apache/struts-committers , I'm going to close this one as already there are users mentioning such things as an information disclosure security issue. objections? |
Hm.. I see Lukasz already has mentioned about that and also as mentioned, it should be user-configurable prefix to avoid information disclosure! |
@aleksandr-m do you think it will be hard to update this PR? Or maybe create a new one? |
@lukaszlenart You mean to allow to change prefix? Do you have an idea how to do that? |
Yes, I know we are supporting a different set of extensions and I do not have a solution at hand. Other option is to develop a new html5 theme from scratch. |
Implements WW-4520