This repository has been archived by the owner on Jul 10, 2024. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
SUBMARINE-673. Fixed Cannot read property 'environment' of null
### What is this PR for? If there is no environment in submarine server, clicking the button "+ New notebook" will output error message "ERROR TypeError: Cannot read property 'environment' of null" to the web console and the modal do not open. 1. Set notebook-env can't be deleted in environment page of UI. 2. Set notebook-env as default environment when create new notebook in notebook page of UI. ### What type of PR is it? [Bug Fix] ### Todos ### What is the Jira issue? https://issues.apache.org/jira/browse/SUBMARINE-673 ### How should this be tested? https://travis-ci.org/github/kobe860219/submarine/builds/742502456 ### Screenshots (if appropriate) ![螢幕錄製 2020-11-10 上午12](https://user-images.githubusercontent.com/48027290/98574254-a9bb8180-22f2-11eb-9b9d-421263afe564.gif) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: kobe860219 <[email protected]> Closes #449 from kobe860219/SUBMARINE-673 and squashes the following commits: b200dfc [kobe860219] SUBMARINE-673. ERROR : Cannot read property 'environment' of null
- Loading branch information