chore: Reduces the form_data_key length (#31905)

apache · Jan 21, 2025 · a02a2f5 · a02a2f5
1 parent dca3efb
commit a02a2f5
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/superset/key_value/shared_entries.py b/superset/key_value/shared_entries.py
@@ -42,6 +42,7 @@ def set_shared_value(key: SharedKey, value: Any) -> None:
 def get_permalink_salt(key: SharedKey) -> str:
     salt = get_shared_value(key)
     if salt is None:
-        salt = random_key()
+        # Use a 48 bytes salt
+        salt = random_key(48)
         set_shared_value(key, value=salt)
     return salt
diff --git a/superset/key_value/utils.py b/superset/key_value/utils.py
@@ -31,8 +31,14 @@
 HASHIDS_MIN_LENGTH = 11
 
 
-def random_key() -> str:
-    return token_urlsafe(48)
+def random_key(nbytes: int = 8) -> str:
+    """
+    Generate a random URL-safe string.
+
+    Args:
+        nbytes (int): Number of bytes to use for generating the key. Default is 8.
+    """
+    return token_urlsafe(nbytes)
 
 
 def get_filter(resource: KeyValueResource, key: Key) -> KeyValueFilter: