fix(sql-lab): recover from Cannot convert object to primitive value i…

[victorarbuesmallada]

…ssue

A Cannot convert object to primitive value error appears in the developer console when trying to format the data coming from Presto. This issue causes the SQL Lab to crash. This can be sorted by stringifying the row data.

SUMMARY

The SQL Lab crashes when data coming from Presto contains non primitive values. This fix basically catches the exception that occurs and recovers by formatting the row data using JSON.stringify. It does the trick in our case.
We also had a look at fixing this on the presto db engine spec but couldn't really fix it over there.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

I guess this is hard to test but, in our case, we have a Presto datasource that returns nested data that blows up the SQL Lab when it's getting formatted in a tabulated way.

ADDITIONAL INFORMATION

• Has associated issue: PRESTO_EXPAND_DATA causes SQL Lab crash #11295
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (fa35109) 66.59% compared to head (a86d850) 65.27%.
Report is 3354 commits behind head on master.

Files	Patch %	Lines
superset-frontend/src/utils/common.js	75.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #19432      +/-   ##
==========================================
- Coverage   66.59%   65.27%   -1.32%     
==========================================
  Files        1670     2109     +439     
  Lines       63888    90076   +26188     
  Branches     6510    13355    +6845     
==========================================
+ Hits        42544    58801   +16257     
- Misses      19654    28165    +8511     
- Partials     1690     3110    +1420     

Flag	Coverage Δ
javascript	55.85% <75.00%> (+4.52%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rusackas]

Hi there! Thanks for the contribution, and sorry it didn't get more attention. Is this still an issue in the current era of Superset? I've added another reviewer that (I believe) uses Trino to validate/assess. I'll also close/reopen this PR to retrigger CI, and perhaps we can get this across the finish line!

[betodealmeida]

Can we add some tests, covering the issue this PR fixes?