-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Boxplot): Allow configuration of y-axis range #24380
base: master
Are you sure you want to change the base?
feat(Boxplot): Allow configuration of y-axis range #24380
Conversation
@dinesh-zemoso could you please add some before/after screenshots to help reviewers better grok the nature of the change? |
Codecov Report
@@ Coverage Diff @@
## master #24380 +/- ##
==========================================
+ Coverage 68.31% 69.07% +0.76%
==========================================
Files 1957 1903 -54
Lines 75596 74541 -1055
Branches 8222 8111 -111
==========================================
- Hits 51640 51487 -153
+ Misses 21848 20942 -906
- Partials 2108 2112 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 103 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
/testenv up |
It still seems quite possible to get this across the finish line. The screenshots requested would sure help. I'm not sure if the ephemeral environment will work or not, but we shall see. Meanwhile, if @kgabryje (or anyone he knows) has time to review and test this locally, maybe we can get it in. |
{ | ||
name: 'show_range_filter', | ||
config: { | ||
type: 'SelectControl', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make it a checkbox like in other Echarts?
Example from bar chart:
[
{
name: 'zoomable',
config: {
type: 'CheckboxControl',
label: t('Data Zoom'),
default: zoomable,
renderTrigger: true,
description: t('Enable data zooming controls'),
},
},
],
|
||
const eventHandlers = allEventHandlers(props); | ||
if (formData.showRangeFilter) { | ||
echartOptions.dataZoom = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should move this logic to transformProps
file
Configurable Y-Axis Range in Box Plots would be quite welcome. That way, if two box plots placed side by side but contain different data ranges within their data (inevitable), the charts could be manually configured to have the same meaningful Y-axis range, so that the chart contents could be visually compared directly. (I wonder if there is a generalized way to add this feature; all charts with a Y-Axis, such as Bar Charts and Line Charts, can also benefit from a manual Y-axis range.) |
SUMMARY
Added a range slider for Box plot parellel to Y-axis where user can select certain range on the Y-axis
Here is the discussion Link : #16745
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION