Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: alerts and reports modal with dashboard filters and tabs [WIP] #26141

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

lilykuang
Copy link
Member

@lilykuang lilykuang commented Nov 30, 2023

SUMMARY

  • this pr is POC for the SIP of alerts and reports modal with dashboard filters and tabs and not going to be merged

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

reportmodal

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@lilykuang lilykuang changed the title report modal with dashboard filters and tab feat: alerts and reports modal with dashboard filters and tabs [WIP] Nov 30, 2023
@lilykuang lilykuang force-pushed the report-modal-with-filters branch from f2882ec to 62527ea Compare November 30, 2023 17:39
@john-bodley
Copy link
Member

john-bodley commented Nov 30, 2023

@lilykuang I realize that this is in draft mode, but my understanding was that the Alerting + Reporting redesign was going to be tied to a SIP. Is this merely a PoC for use in the SIP?

@lilykuang lilykuang force-pushed the report-modal-with-filters branch from 62527ea to 9476ec1 Compare December 1, 2023 06:20
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 54 lines in your changes are missing coverage. Please review.

Comparison is base (1fbc762) 69.18% compared to head (2497ac5) 69.13%.

Files Patch % Lines
...ures/alerts/components/DashboardFiltersAndTabs.tsx 2.12% 46 Missing ⚠️
...-frontend/src/features/alerts/AlertReportModal.tsx 28.57% 4 Missing and 1 partial ⚠️
...et-frontend/src/dashboard/actions/nativeFilters.ts 50.00% 1 Missing ⚠️
superset-frontend/src/dataMask/actions.ts 66.66% 1 Missing ⚠️
superset-frontend/src/dataMask/reducer.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26141      +/-   ##
==========================================
- Coverage   69.18%   69.13%   -0.05%     
==========================================
  Files        1945     1946       +1     
  Lines       75948    76008      +60     
  Branches     8458     8476      +18     
==========================================
+ Hits        52544    52550       +6     
- Misses      21219    21272      +53     
- Partials     2185     2186       +1     
Flag Coverage Δ
javascript 56.44% <10.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lilykuang
Copy link
Member Author

yes, @john-bodley this pr is a PoC for Alerts and Report modal and it's not going to be merged

@eschutho
Copy link
Member

eschutho commented Dec 1, 2023

/testenv up

Copy link
Contributor

github-actions bot commented Dec 1, 2023

@eschutho Ephemeral environment spinning up at http://34.215.251.39:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@eschutho
Copy link
Member

eschutho commented Dec 1, 2023

/testenv up FEATURE_ALERT_REPORTS=true

Copy link
Contributor

github-actions bot commented Dec 1, 2023

@eschutho Ephemeral environment spinning up at http://54.187.177.192:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@lilykuang lilykuang force-pushed the report-modal-with-filters branch from 9476ec1 to 2497ac5 Compare December 11, 2023 18:04
@lilykuang
Copy link
Member Author

/testenv up FEATURE_ALERT_REPORTS=true

Copy link
Contributor

@lilykuang Ephemeral environment spinning up at http://34.209.239.80:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 10.00000% with 54 lines in your changes missing coverage. Please review.

Project coverage is 69.13%. Comparing base (1fbc762) to head (2497ac5).
Report is 1662 commits behind head on master.

Files with missing lines Patch % Lines
...ures/alerts/components/DashboardFiltersAndTabs.tsx 2.12% 46 Missing ⚠️
...-frontend/src/features/alerts/AlertReportModal.tsx 28.57% 4 Missing and 1 partial ⚠️
...et-frontend/src/dashboard/actions/nativeFilters.ts 50.00% 1 Missing ⚠️
superset-frontend/src/dataMask/actions.ts 66.66% 1 Missing ⚠️
superset-frontend/src/dataMask/reducer.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26141      +/-   ##
==========================================
- Coverage   69.18%   69.13%   -0.05%     
==========================================
  Files        1945     1946       +1     
  Lines       75948    76008      +60     
  Branches     8458     8476      +18     
==========================================
+ Hits        52544    52550       +6     
- Misses      21219    21272      +53     
- Partials     2185     2186       +1     
Flag Coverage Δ
javascript 56.44% <10.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants