-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: alerts and reports modal with dashboard filters and tabs [WIP] #26141
base: master
Are you sure you want to change the base?
Conversation
f2882ec
to
62527ea
Compare
@lilykuang I realize that this is in draft mode, but my understanding was that the Alerting + Reporting redesign was going to be tied to a SIP. Is this merely a PoC for use in the SIP? |
62527ea
to
9476ec1
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #26141 +/- ##
==========================================
- Coverage 69.18% 69.13% -0.05%
==========================================
Files 1945 1946 +1
Lines 75948 76008 +60
Branches 8458 8476 +18
==========================================
+ Hits 52544 52550 +6
- Misses 21219 21272 +53
- Partials 2185 2186 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yes, @john-bodley this pr is a PoC for Alerts and Report modal and it's not going to be merged |
/testenv up |
@eschutho Ephemeral environment spinning up at http://34.215.251.39:8080. Credentials are |
/testenv up FEATURE_ALERT_REPORTS=true |
@eschutho Ephemeral environment spinning up at http://54.187.177.192:8080. Credentials are |
9476ec1
to
2497ac5
Compare
/testenv up FEATURE_ALERT_REPORTS=true |
@lilykuang Ephemeral environment spinning up at http://34.209.239.80:8080. Credentials are |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #26141 +/- ##
==========================================
- Coverage 69.18% 69.13% -0.05%
==========================================
Files 1945 1946 +1
Lines 75948 76008 +60
Branches 8458 8476 +18
==========================================
+ Hits 52544 52550 +6
- Misses 21219 21272 +53
- Partials 2185 2186 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION