-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: add possibility to deploy under the URI prefix #26320
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1be5322
to
a2f7717
Compare
a2f7717
to
bb6e589
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #26320 +/- ##
==========================================
- Coverage 69.18% 69.17% -0.01%
==========================================
Files 1946 1946
Lines 75969 75989 +20
Branches 8469 8481 +12
==========================================
+ Hits 52560 52569 +9
- Misses 21223 21230 +7
- Partials 2186 2190 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
a707aad
to
d2d50bb
Compare
d2d50bb
to
113dffc
Compare
@@ -60,7 +60,7 @@ | |||
{% endif %} | |||
|
|||
{% endblock %} | |||
|
|||
<script>window.__SUPERSET_DEPLOYMENT_PREFIX__ = "{{ assets_prefix }}";</script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I understand assets_prefix
is initialized in "/superset/extensions/init.py" using the STATIC_ASSETS_PREFIX
configuration variable, but i cannot see how and where ASSET_BASE_URL
(Dockerfile) is assigned to be used after in the withPrefix()
function
@jinghua-qa @geido @eschutho @rusackas @betodealmeida Could you review this PR? It is important to be able to deploy superset behind a reverse-proxy using a different URI prefix #20213 #18364 #25500 |
Hey, is there any news on this? I'd find ti really really useful |
#26319 26319
Refactoring of the redirects and url generation on the frontend and backend