Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: add possibility to deploy under the URI prefix #26320

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

vadym-serdiuk
Copy link

#26319 26319

Refactoring of the redirects and url generation on the frontend and backend

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@vadym-serdiuk vadym-serdiuk force-pushed the prefix-deployment branch 2 times, most recently from 1be5322 to a2f7717 Compare December 20, 2023 15:29
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 40 lines in your changes are missing coverage. Please review.

Comparison is base (aa3c3c5) 69.18% compared to head (a707aad) 69.17%.
Report is 33 commits behind head on master.

Files Patch % Lines
superset/views/core.py 56.25% 7 Missing ⚠️
...perset-frontend/src/pages/SavedQueryList/index.tsx 0.00% 4 Missing ⚠️
superset/views/database/views.py 72.72% 3 Missing ⚠️
superset-frontend/src/features/home/ChartTable.tsx 0.00% 2 Missing ⚠️
...rset-frontend/src/features/home/DashboardTable.tsx 0.00% 2 Missing ⚠️
superset-frontend/src/views/CRUD/hooks.ts 0.00% 2 Missing ⚠️
...rontend/src/SqlLab/components/QueryTable/index.tsx 0.00% 1 Missing ⚠️
...erset-frontend/src/components/Chart/chartAction.js 0.00% 1 Missing ⚠️
...et-frontend/src/dashboard/components/SaveModal.tsx 0.00% 1 Missing ⚠️
...rd/components/nativeFilters/FilterBar/keyValue.tsx 0.00% 1 Missing ⚠️
... and 16 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26320      +/-   ##
==========================================
- Coverage   69.18%   69.17%   -0.01%     
==========================================
  Files        1946     1946              
  Lines       75969    75989      +20     
  Branches     8469     8481      +12     
==========================================
+ Hits        52560    52569       +9     
- Misses      21223    21230       +7     
- Partials     2186     2190       +4     
Flag Coverage Δ
hive 53.69% <30.15%> (+0.02%) ⬆️
javascript 56.52% <44.18%> (+<0.01%) ⬆️
mysql 78.05% <73.01%> (-0.04%) ⬇️
postgres 78.17% <74.60%> (-0.02%) ⬇️
presto 53.65% <30.15%> (+0.02%) ⬆️
python 82.85% <74.60%> (-0.01%) ⬇️
sqlite 76.82% <73.01%> (-0.02%) ⬇️
unit 55.81% <28.57%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the api Related to the REST API label Feb 7, 2024
@@ -60,7 +60,7 @@
{% endif %}

{% endblock %}

<script>window.__SUPERSET_DEPLOYMENT_PREFIX__ = "{{ assets_prefix }}";</script>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understand assets_prefix is initialized in "/superset/extensions/init.py" using the STATIC_ASSETS_PREFIX configuration variable, but i cannot see how and where ASSET_BASE_URL (Dockerfile) is assigned to be used after in the withPrefix() function

@nachogrj
Copy link

@jinghua-qa @geido @eschutho @rusackas @betodealmeida Could you review this PR? It is important to be able to deploy superset behind a reverse-proxy using a different URI prefix #20213 #18364 #25500

@jbsiddall
Copy link

Hey, is there any news on this? I'd find ti really really useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants