feat(deckgl-map): add tile server layer support #27476
Open
+78
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
fxprunayre
force-pushed
the
feat-chart-map-tile-server-support
branch
from
2aec87e to
bd9f8d1
Compare
In the DeckGL map plugin we can only select a Mapbox style from the [predefined list](https://github.com/apache/superset/blob/2499a1cf5a7f298c1ee2f34b3d67ca1d18bb7457/superset-frontend/plugins/legacy-preset-chart-deckgl/src/utilities/Shared_DeckGL.jsx#L373-L380) or [typing a new Mapbox style URL](apache#26031). This change add support for tile server layer making use of Deck.gl [TileLayer](https://deck.gl/docs/api-reference/geo-layers/tile-layer). The well known OpenStreeMap layer provided by https://[abc].tile.openstreetmap.org/{z}/{x}/{y}.png is added to the list making easier for users not having a Mapbox account to have a background layer on map charts. It has been tested with other tile server URL eg. tile://https://tile.osm.ch/name-it/{z}/{x}/{y}.png
fxprunayre
force-pushed
the
feat-chart-map-tile-server-support
branch
from
bd9f8d1 to
55e122c
Compare
|
When running
|
|
Hello ! Any update on this PR ? |
|
Relates to a SIP where we want to move from MapBox to MapLibre: |
|
Closing and reopening to kickstart CI. |
|
Maybe @Mattc1221 would be interested in reviewing this! |
|
Tank you @rusackas ! And thank you in advance @Mattc1221 ! |
|
Looks like the frontend build is failing CI, but I'm re-running it in case we get lucky. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
In the DeckGL map plugin we can only select a Mapbox style from the predefined list or typing a new Mapbox style URL.
This change add support for tile server layer making use of Deck.gl TileLayer. The well known OpenStreeMap layer provided by https://[abc].tile.openstreetmap.org/{z}/{x}/{y}.png is added to the list making easier for users not having a Mapbox account to have a background layer on map charts.
It has been tested with other tile server URL
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Choose Mapbox, Openstreetmap or use a custom mapbox or tile URL
OSM background layer
TESTING INSTRUCTIONS
Select the OpenStreetMap background layer or paste a tile server URL eg.
tile://https://tile.osm.ch/name-it/{z}/{x}/{y}.png,tile://https://c.tile.openstreetmap.org/{z}/{x}/{y}.pngADDITIONAL INFORMATION