-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: show_filters
URL parameter is not working
#29422
base: master
Are you sure you want to change the base?
Conversation
Thanks for the PR, @hexcafe. Hey @michael-s-molina @john-bodley, I checked out this PR locally and tested and it works ✅ but since I'm just getting familiar with frontend I wanted to get your thoughts. I didn't think so, but this also works with the horizontal filter bar 🙌 Thanks! |
@hexcafe @Vitor-Avila Shouldn't we just revert this part that was deleted in #23228? |
Any news about this PR? |
Would be great to see this one merged into next release. |
Can we please get this reviewed? |
@michael-s-molina would you prefer to have that code block restored as opposed to using the approach in this PR? |
@Vitor-Avila It seems we should restore that code given that |
SUMMARY
Problem:
When embedding the dashboard, the filter panel does not hide even when
show_filters
is set tofalse
.After a quick investigation, I found that this parameter is not being handled at all.
Expected Behavior:
show_filters
parameter is explicitly set tofalse
or0
.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION