feat(sqllab): Replace FilterableTable by AgGrid Table #29900
Conversation
dosubot
bot
added
change:frontend
justinpark
requested review from
rusackas,
betodealmeida,
yousoph,
kasiazjc and
michael-s-molina
|
@justinpark this looks great! I think I might have asked this question before, so apologies if I did, but for how long custom table settings are kept - just for session and just for this specific query? |
|
/testenv up |
|
@yousoph Ephemeral environment spinning up at http://35.160.157.54:8080. Credentials are |
You're right. This will only apply to the current query in the current session. I considered saving it, but I thought it might be better not to, as revisiting the query later when the memory has faded could cause confusion with different items being displayed in the query results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #29900 +/- ##
===========================================
+ Coverage 60.48% 83.46% +22.97%
===========================================
Files 1931 546 -1385
Lines 76236 39276 -36960
Branches 8568 0 -8568
===========================================
- Hits 46114 32783 -13331
+ Misses 28017 6493 -21524
+ Partials 2105 0 -2105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rusackas
requested review from
kgabryje,
Antonio-RiveroMartnez and
eschutho
justinpark
force-pushed
the
feat--ag-grid-for-filterable-table
branch
from
e5d9e67 to
c4ae211
Compare
|
when is the release target date and release version ? |
justinpark
force-pushed
the
feat--ag-grid-for-filterable-table
branch
from
61e0bb6 to
741b5b1
Compare
@Hokwang this will most likely be released in 5.0 around April 2025. |
|
/testenv up |
|
@eschutho Ephemeral environment spinning up at http://44.243.18.92:8080. Credentials are |
|
@eschutho Thanks for your comment, but I can't find at 5.0 project. Please add this item. |
@Hokwang The 5.0 project board contain only breaking changes that need consensus which is not the case for this PR. That does not mean that only what's in the board will be released. On February 3rd, we'll cut from master branch and all PRs merged by then will be included in the release. Check our Release Process for more details. |
|
@michael-s-molina Oh, I see. Thanks for more detail information. |
justinpark
force-pushed
the
feat--ag-grid-for-filterable-table
branch
from
741b5b1 to
7d410d0
Compare
|
/testenv up |
|
@justinpark Processing your ephemeral environment request here. |
|
@justinpark Ephemeral environment spinning up at http://52.33.205.29:8080. Credentials are |
justinpark
force-pushed
the
feat--ag-grid-for-filterable-table
branch
from
3d526f3 to
e5b0967
Compare
SUMMARY
Following up #27645, This commit includes the migration of the component used for SQLLab results from the ant-table component to the ag-grid component.
During this process, the existing logic(
getWidthsForColumns) that measured column size to adjust the width was removed because it was not only performance-intensive but also unnecessary, as the resizable column option in ag-grid allows users to adjust the width as needed.Additionally, other property options were modified to ensure compatibility with ag-grid. Moreover, a column menu feature was added, enabling users to pin specific columns and apply filters.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
Header menu (Actions):
TESTING INSTRUCTIONS
Go to SQL Lab and run a query to explore the data
ADDITIONAL INFORMATION