Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dashboard): Backward compatible shared_label_colors field #31163

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

geido
Copy link
Member

@geido geido commented Nov 26, 2024

SUMMARY

A follow-up PR for #30646. This PR ensure that a dashboard that used the shared_label_colors field as a dict is compatible with the shared_label_colors being a list as per the latest changes and can be re-imported / copied without errors.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N.A.

TESTING INSTRUCTIONS

  1. Export a Dashboard before changes in fix(Dashboard): Retain colors when color scheme not set #30646
  2. Re-import the Dashboard after changes in fix(Dashboard): Retain colors when color scheme not set #30646
  3. Copy the dashboard and all of its charts utilizing "Save as"
  4. Copying the dashboard should work without errors

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added dashboard:export Related to exporting dashboards dashboard:import Related to importing dashboards labels Nov 26, 2024
@geido geido changed the title fix(Dashboard): Backward compatible shared_label_colors field for export fix(Dashboard): Backward compatible shared_label_colors field Nov 26, 2024
@geido geido force-pushed the geido/fix/shared-label-colors-export branch from 8b84832 to 6473532 Compare November 26, 2024 15:01
@pull-request-size pull-request-size bot added size/M and removed size/S labels Nov 26, 2024
@geido geido force-pushed the geido/fix/shared-label-colors-export branch from 6473532 to 0633c67 Compare November 26, 2024 15:25
@geido geido force-pushed the geido/fix/shared-label-colors-export branch from 0633c67 to 227fe62 Compare November 26, 2024 17:57
@geido geido force-pushed the geido/fix/shared-label-colors-export branch from 227fe62 to 5873caa Compare November 26, 2024 17:58
@sadpandajoe sadpandajoe added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Nov 26, 2024
@geido geido merged commit f077323 into master Nov 26, 2024
35 checks passed
@sadpandajoe sadpandajoe deleted the geido/fix/shared-label-colors-export branch November 26, 2024 19:29
sadpandajoe pushed a commit that referenced this pull request Dec 4, 2024
betodealmeida pushed a commit that referenced this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard:export Related to exporting dashboards dashboard:import Related to importing dashboards size/M v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch
Projects
Status: Cherried
Development

Successfully merging this pull request may close these issues.

3 participants