fix(date_parser): enhance date parsing for time range filters #31372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
zhaoyongjie
requested changes
Dec 10, 2024
Comment on lines
-293
to
-304
| result = datetime_eval("datetime('2018-9')") | ||
| expected = datetime(2018, 9, 1) | ||
| assert result == expected | ||
|
|
||
| # Parse compact arguments spelling | ||
| result = datetime_eval("dateadd(datetime('today'),1,year,)") | ||
| expected = datetime(2017, 11, 7) | ||
| assert result == expected | ||
|
|
||
| result = datetime_eval("dateadd(datetime('today'), -2, year)") | ||
| expected = datetime(2014, 11, 7) | ||
| assert result == expected |
There was a problem hiding this comment.
I think you should understand what the previous logic did and then remove the unit test again.
|
Due to the significant changes, failing tests and lack of response to review comments, I assume this was supposed to target a fork, not upstream. Closing, but feel free to reopen if this is not the case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR addresses the date parsing issues related to time range filters as reported in Issue #30592. The changes made to the
date_parser.pyfile enhance the handling of various date formats, including relative dates and specific time components. Theparse_human_datetimefunction has been updated to correctly parse inputs such as "today, HH:MM:SS" and "today, HH:MM".fixes: #30592
TESTING INSTRUCTIONS
tests/unit_tests/utils/date_parser_tests.pyto verify that all tests pass.ADDITIONAL INFORMATION