-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(Popover): Upgrade Popover to Antd5 #31973
base: master
Are you sure you want to change the base?
refactor(Popover): Upgrade Popover to Antd5 #31973
Conversation
Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
Category | Issue | Fix Detected |
---|---|---|
Filter popover z-index issue in full-size mode ▹ view | ✅ | |
Redundant Z-Index Configuration ▹ view | ✅ | |
Unreliable Header Access ▹ view |
Need a new review? Comment
/korbit-review
on this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-review
command in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-description
command in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolve
command in any comment on your PR.- Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Feedback and Support
superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/cypress-base/cypress/e2e/dashboard/horizontalFilterBar.test.ts
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/FiltersBadge/DetailsPanel/index.tsx
Show resolved
Hide resolved
superset-frontend/src/explore/components/DataTableControl/index.tsx
Outdated
Show resolved
Hide resolved
@alexandrusoare regarding Popover.stories.tsx, could you add the default values for TRIGGERS i think 'click, 'top' for PLACEMENTS, and include a state that changes based on the selected triggers? For example, when you click the button, the popover should open, or it should change when the selected trigger is changed, for make it interactive. Recording.2025-01-27.234116.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, minor gripe for me is default exports but i've seen it used in other places so i think it's fine
@@ -181,11 +181,13 @@ const DropdownContainer = forwardRef( | |||
); | |||
|
|||
useLayoutEffect(() => { | |||
if (popoverVisible) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add it to the dependency array?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I don't think so, I added this statement because of a visual bug that was happening in certain cases. And I think that we don't need to recalculate the size when popover is closed .
SUMMARY
Upgrading Popover component to Antd5.
Fixes #31953
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE
AFTER
BEFORE
AFTER
BEFORE
AFTER
BEFORE
AFTER
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION