Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEZ-4522: Use OpenFile where FileStatus is available. #318

Merged
merged 4 commits into from
Dec 4, 2023

Conversation

ayushtkn
Copy link
Member

@ayushtkn ayushtkn commented Dec 4, 2023

No description provided.

@tez-yetus

This comment was marked as outdated.

@tez-yetus

This comment was marked as outdated.

Copy link
Contributor

@abstractdog abstractdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 pending tests

@tez-yetus

This comment was marked as outdated.

@tez-yetus

This comment was marked as outdated.

@tez-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 22m 48s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗 mvndep 6m 11s Maven dependency ordering for branch
+1 💚 mvninstall 11m 55s master passed
+1 💚 compile 3m 12s master passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04
+1 💚 compile 2m 39s master passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08
+1 💚 checkstyle 2m 55s master passed
+1 💚 javadoc 2m 32s master passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04
+1 💚 javadoc 2m 19s master passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08
+0 🆗 spotbugs 0m 36s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 5m 12s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for patch
+1 💚 mvninstall 1m 42s the patch passed
+1 💚 compile 1m 46s the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04
+1 💚 javac 1m 46s the patch passed
+1 💚 compile 1m 36s the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08
+1 💚 javac 1m 36s the patch passed
+1 💚 checkstyle 1m 11s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 1m 19s the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04
+1 💚 javadoc 1m 16s the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08
+1 💚 findbugs 4m 25s the patch passed
_ Other Tests _
+1 💚 unit 2m 17s tez-api in the patch passed.
+1 💚 unit 5m 34s tez-runtime-library in the patch passed.
+1 💚 unit 1m 24s tez-mapreduce in the patch passed.
+1 💚 unit 5m 12s tez-dag in the patch passed.
+1 💚 unit 0m 13s tez-tfile-parser in the patch passed.
+1 💚 asflicense 0m 50s The patch does not generate ASF License warnings.
90m 49s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-318/6/artifact/out/Dockerfile
GITHUB PR #318
JIRA Issue TEZ-4522
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
uname Linux d1cd837a6a68 5.15.0-86-generic #96-Ubuntu SMP Wed Sep 20 08:23:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / 0ed5e32
Default Java Private Build-1.8.0_392-8u392-ga-1~22.04-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~22.04-b08
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-318/6/testReport/
Max. process+thread count 2100 (vs. ulimit of 5500)
modules C: tez-api tez-runtime-library tez-mapreduce tez-dag tez-tools/tez-tfile-parser U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-318/6/console
versions git=2.34.1 maven=3.6.3 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdog
Copy link
Contributor

latest precommit looks good

@abstractdog abstractdog merged commit 0c5cf68 into apache:master Dec 4, 2023
4 checks passed
prabhjyotsingh added a commit to acceldata-io/tez that referenced this pull request Oct 22, 2024
…#318) (Ayush Saxena reviewed by Laszlo Bodor)"

This reverts commit 0c5cf68.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants