Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEZ-4557: Revert TEZ-4303, NoClassDefFoundError because of missing httpclient jar #349

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

Aggarwal-Raghav
Copy link
Contributor

Please refer to TEZ-4557, for error stacktrace.

@tez-yetus

This comment was marked as outdated.

@Aggarwal-Raghav
Copy link
Contributor Author

@abstractdog, can you please review this?

@abstractdog
Copy link
Contributor

@abstractdog, can you please review this?

according to my jira comment, I'm about to approve this
can you rebase your PR on top of master @Aggarwal-Raghav to get a green precommit test run

@Aggarwal-Raghav
Copy link
Contributor Author

Rebased. Thanks for the review @abstractdog.

@Aggarwal-Raghav
Copy link
Contributor Author

Will force push the commit again, as there is failure in git workflows. Error seems unrelated to the patch.
Error: Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.8.0:install-node-and-yarn (install node and yarn) on project tez-ui: Could not download Node.js: Got error code 500 from the server. -> [Help 1]

@tez-yetus

This comment was marked as outdated.

@tez-yetus

This comment was marked as outdated.

@Aggarwal-Raghav
Copy link
Contributor Author

Test seems to be passing on local
Screenshot 2024-06-25 at 7 24 51 PM

will trigger the CI one more time!

@abstractdog
Copy link
Contributor

Test seems to be passing on local Screenshot 2024-06-25 at 7 24 51 PM

will trigger the CI one more time!

TestAnalyzer is flaky

@Aggarwal-Raghav
Copy link
Contributor Author

Wasn't aware of it, have triggered it now 🥲.

@tez-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 12s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 16m 45s master passed
+1 💚 compile 2m 16s master passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu122.04.1
+1 💚 compile 2m 3s master passed with JDK Private Build-1.8.0_412-8u412-ga-1~22.04.1-b08
+1 💚 javadoc 1m 45s master passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu122.04.1
+1 💚 javadoc 1m 9s master passed with JDK Private Build-1.8.0_412-8u412-ga-1~22.04.1-b08
_ Patch Compile Tests _
+1 💚 mvninstall 4m 14s the patch passed
+1 💚 compile 2m 14s the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu122.04.1
+1 💚 javac 2m 14s the patch passed
+1 💚 compile 2m 4s the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~22.04.1-b08
+1 💚 javac 2m 4s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
+1 💚 javadoc 1m 11s the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu122.04.1
+1 💚 javadoc 1m 10s the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~22.04.1-b08
_ Other Tests _
-1 ❌ unit 61m 10s root in the patch failed.
+1 💚 asflicense 0m 40s The patch does not generate ASF License warnings.
98m 5s
Reason Tests
Failed junit tests tez.test.TestRecovery
Subsystem Report/Notes
Docker ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-349/4/artifact/out/Dockerfile
GITHUB PR #349
JIRA Issue TEZ-4557
Optional Tests dupname asflicense javac javadoc unit xml compile
uname Linux c67e5978f752 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / 19b2351
Default Java Private Build-1.8.0_412-8u412-ga-1~22.04.1-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu122.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_412-8u412-ga-1~22.04.1-b08
unit https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-349/4/artifact/out/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-349/4/testReport/
Max. process+thread count 2100 (vs. ulimit of 5500)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-349/4/console
versions git=2.34.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@deniskuzZ
Copy link
Member

deniskuzZ commented Jun 27, 2024

@abstractdog, is there a possibility of Tez release that includes this fix before Hive-4.0.1
cc @ayushtkn, @dengzhhu653

@abstractdog
Copy link
Contributor

@abstractdog, is there a possibility of Tez release that includes this fix before Hive-4.0.1 cc @ayushtkn, @dengzhhu653

not sure, even if we merge this now, and initiate a release process for Tez 0.10.4, it's a matter of weeks, usually at least a month until we get PMC member votes

@abstractdog abstractdog self-requested a review June 28, 2024 03:59
@abstractdog
Copy link
Contributor

ignoring any further recovery flaky failures, merging this to master

@abstractdog abstractdog merged commit c745edf into apache:master Jun 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants