refactor: standardize the HTML, CSS and JSP in the webapps folder. #316
Conversation
|
error.html:
|
|
Hey @kkolinko I removed the I also validated the 'error.html' by direct upload and it validates now. |
jbampton
force-pushed
the
fix-html
branch
7 times, most recently
from
0b8fdf7 to
e844277
Compare
| @@ -25,11 +25,11 @@ request.setAttribute("tomcatExamplesUrl", "/examples/"); | |||
| <!DOCTYPE html> | |||
| <html lang="en"> | |||
| <head> | |||
| <meta charset="UTF-8" /> | |||
| <meta charset="UTF-8"> | |||
There was a problem hiding this comment.
Why did you remove the auto-closing ? It doesn't do any harm. I, personally, prefer the style it was before.
There was a problem hiding this comment.
In HTML5 you don't need the auto-closing.
I got the style from MDN.
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meta
There was a problem hiding this comment.
I know, but it does not do any harm either.
This change makes the diff bigger and harder to back-port to the other branches.
I prefer the XHTML style because it is easier to spot errors in the IDE/text editor without copying to W3C validator in the web.
MDN says -> Possible (case insensitive) values
|
jbampton
force-pushed
the
fix-html
branch
8 times, most recently
from
bb5d215 to
735e437
Compare
jbampton
changed the title
jbampton
force-pushed
the
fix-html
branch
2 times, most recently
from
8c818fe to
1e7d050
Compare
Use lowercase HTML tags and attributes. Add quotes around attributes. Fix some HTML errors. Use HTML5 and CSS. Indent HTML and JSP. Remove whitespace. Remove blank lines. Standardize quotes.
jbampton
changed the title
|
I'm a -1 on this change mostly because it's so large with so many changes at the same time. If this PR had been the accumulation of several commits e.g. (1) re-format whitespace everywhere with no other changes then (2) remove unnecessary auto-close elements then (3) standardize quoting, etc. then it would have been easier to review, spot things we didn't like, etc. But this is one giant change I'm unwilling to read through to decide if I like every single one of them so, no. |
Use lowercase HTML tags and attributes.
Add quotes around attributes.
Standardize quotes.
Fix some HTML errors.
Use HTML5 and CSS.
Remove whitespace and blank lines.
Indent HTML and JSP.