-
Notifications
You must be signed in to change notification settings - Fork 818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
THREAD_FREE: rely less on macros #11943
base: master
Are you sure you want to change the base?
Conversation
Move as much of the implementation of THREAD_FREE as possible into a type-safe function. This was already done for THREAD_ALLOC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good change.
Do you think thread_free
should be marked inline?
I don't know. We don't need it to comply with ODR since the function is a template function. My understanding is that modern compilers are already smart about whether to inline the function, so it's hard to say whether adding the keyword will help with performance. |
In case it's helpful, here's the clang analyzer report from the artifact's directory of the job: |
[approve ci autest] |
Move as much of the implementation of THREAD_FREE as possible into a type-safe function. This was already done for THREAD_ALLOC.