Skip to content

[BugFix][CUDA] Increase FloatImm precision when printing 64 bit values in CUDA codegen #17530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[BugFix][CUDA] Increase FloatImm precision when printing 64 bit values in CUDA codegen #17530

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3190324
increase precision when printing 64 bit constants (FloatImmNode visit…
SerodioJ Nov 14, 2024
ec4b856
add missing bracket from switch case
SerodioJ Nov 26, 2024
901c37e
fix switch case 32
SerodioJ Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 21 additions & 5 deletions src/target/source/codegen_cuda.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1381,21 +1381,37 @@ inline void PrintConst(const FloatImmNode* op, std::ostream& os, CodeGenCUDA* p)
}
// Type code is kFloat
switch (op->dtype.bits()) {
case 64:
case 64: {
std::ostringstream temp;
if (std::isinf(op->value)) {
if (op->value < 0) {
temp << "-";
}
temp << "CUDART_INF";
p->need_math_constants_h_ = true;
} else if (std::isnan(op->value)) {
temp << "CUDART_NAN";
p->need_math_constants_h_ = true;
} else {
temp << std::fixed << std::setprecision(15) << op->value;
}
p->MarkConst(temp.str());
os << temp.str();
break;
}
case 32: {
std::ostringstream temp;
if (std::isinf(op->value)) {
if (op->value < 0) {
temp << "-";
}
temp << ((op->dtype.bits() == 32) ? "CUDART_INF_F" : "CUDART_INF");
temp << "CUDART_INF_F";
p->need_math_constants_h_ = true;
} else if (std::isnan(op->value)) {
temp << ((op->dtype.bits() == 32) ? "CUDART_NAN_F" : "CUDART_NAN");
temp << "CUDART_NAN_F";
p->need_math_constants_h_ = true;
} else {
temp << std::scientific << op->value;
if (op->dtype.bits() == 32) temp << 'f';
temp << std::scientific << op->value << 'f';
}
p->MarkConst(temp.str());
os << temp.str();
Expand Down