[YUNIKORN-2998] tryNodesNoReserve is not tested

[kousei47747]

What is this PR for?

Add unit test for tryNodesNoReserve, including 5 test cases:

• Node is the reserved node
• Node is unschedulable
• Node does not have enough resources
• Node fails predicate
• Allocation succeeds

What type of PR is it?

• - Bug Fix
• - Improvement
• - Feature
• - Documentation
• - Hot Fix
• - Refactoring

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2998

[ryankert01]

overall lgtm! btw, is there a way to cover L1430?

[kousei47747]

@ryankert01 Thanks for reviewing! I've added the variables and another test case, the code coverage has now reached 100%. PTAL :)

• yunikorn-core/pkg/scheduler/objects/utilities_test.go

  Lines 51 to 53 in 859a760

  	nodeID3 = "node-3"
  	nodeID4 = "node-4"
  	nodeID5 = "node-5"

• yunikorn-core/pkg/scheduler/objects/application_test.go

  Lines 3635 to 3642 in 859a760

  	// case 4: node fails predicate
  	mockPlugin := mockCommon.NewPredicatePlugin(false, map[string]int{nodeID4: 1})
  	plugins.RegisterSchedulerPlugin(mockPlugin)
  	defer plugins.UnregisterSchedulerPlugins()
  	node4 := newNode(nodeID4, map[string]resources.Quantity{"first": 5})
  	iterator = getNodeIteratorFn(node4)
  	result = app.tryNodesNoReserve(ask, iterator(), node1.NodeID)
  	assert.Assert(t, result == nil, "result should be nil since node4 fails predicate")

[ryankert01]

edit: sorry, I forget to fetch the new code. It's indeed 100% and has L1430 covered. great work!

---

L1430 still not covered, but I think it might be fine if there's no way to do it.

also leaves some comments.

[ryankert01]

lgtm

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.48%. Comparing base (a351764) to head (3cfe7d0).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1008      +/-   ##
==========================================
+ Coverage   82.34%   82.48%   +0.14%     
==========================================
  Files          97       97              
  Lines       15627    15627              
==========================================
+ Hits        12868    12890      +22     
+ Misses       2479     2457      -22     
  Partials      280      280              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[chenyulin0719]

+1 LGTM