[YUNIKORN-2907] Queue config processing log spew #1009
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1009 +/- ##
==========================================
- Coverage 82.34% 82.20% -0.14%
==========================================
Files 97 97
Lines 15627 15674 +47
==========================================
+ Hits 12868 12885 +17
- Misses 2479 2510 +31
+ Partials 280 279 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
@kousei47747 thanks for this patch. There is one small question remaining. Please take a look.
pkg/scheduler/objects/queue.go
Outdated
| return queue, err | ||
| } | ||
|
|
||
| // NewConfiguredShadowQueue creates a new queue from scratch based on the configuration and logs at debug level |
There was a problem hiding this comment.
Hi @kousei47747, thank you for your contribution!
Could you provide more details about the differences between NewConfiguredQueue and NewConfiguredShadowQueue?
Currently, it appears the only difference is the log level, which may be confusing for those unfamiliar with shadow queues.
It would be helpful to explain when developers should use NewConfiguredQueue versus NewConfiguredShadowQueue.
There was a problem hiding this comment.
@blueBlue0102 thanks for reviewing! I will provide more detailed description in the new patch.
|
I dropped a large comment into the jira to provide some guidance and point out another issue. |
|
@wilfred-s thanks for reviewing! I've replied on jira, please take a look. |
|
I’ve updated the PR based on the guidance and noticed that |
What is this PR for?
Logs the shadow queue structure created during configuration update at debug level with a different message to prevent log spew and avoid misleading information.
What type of PR is it?
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2907