Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2760] make tools should check the version of tools #934

Closed
wants to merge 2 commits into from

Conversation

blueBlue0102
Copy link
Contributor

What is this PR for?

This PR addresses the same issue as apache/yunikorn-k8shim#880.

What type of PR is it?

  • - Improvement

What is the Jira issue?

YUNIKORN-2760

How should this be tested?

Pass the GitHub Action CI flow.
You can see the successful run in my forked repo: Link

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.28%. Comparing base (4aec626) to head (9648843).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #934      +/-   ##
==========================================
+ Coverage   79.27%   79.28%   +0.01%     
==========================================
  Files          97       97              
  Lines       12274    12274              
==========================================
+ Hits         9730     9732       +2     
+ Misses       2260     2258       -2     
  Partials      284      284              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pbacsko pbacsko self-requested a review August 7, 2024 13:02
Copy link
Contributor

@pbacsko pbacsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@pbacsko pbacsko closed this in 25dc90f Aug 7, 2024
manirajv06 pushed a commit to manirajv06/incubator-yunikorn-core that referenced this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants