Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2855] Rethink the call for update metrics with nil resource #960

Closed
wants to merge 6 commits into from

Change lock type

d520339
Select commit
Loading
Failed to load commit list.
Closed

[YUNIKORN-2855] Rethink the call for update metrics with nil resource #960

Change lock type
d520339
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 17, 2024 in 0s

80.96% (+0.01%) compared to 9e10746

View this Pull Request on Codecov

80.96% (+0.01%) compared to 9e10746

Details

Codecov Report

Attention: Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.96%. Comparing base (9e10746) to head (d520339).

Files with missing lines Patch % Lines
pkg/metrics/queue.go 76.92% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #960      +/-   ##
==========================================
+ Coverage   80.95%   80.96%   +0.01%     
==========================================
  Files          97       97              
  Lines       12514    12527      +13     
==========================================
+ Hits        10131    10143      +12     
- Misses       2113     2115       +2     
+ Partials      270      269       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.