code review

apache · Aug 11, 2024 · 47ba6d5 · 47ba6d5
1 parent 6849dcc
commit 47ba6d5
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/pkg/cache/context.go b/pkg/cache/context.go
@@ -305,9 +305,7 @@ func (ctx *Context) updateYuniKornPod(appID string, pod *v1.Pod) {
 
 	// treat terminated pods like a remove
 	if utils.IsPodTerminated(pod) {
-		if app != nil {
-			ctx.notifyTaskComplete(app, taskID)
-		}
+		ctx.notifyTaskComplete(app, taskID)
 		log.Log(log.ShimContext).Debug("Request to update terminated pod, removing from cache", zap.String("podName", pod.Name))
 		ctx.schedulerCache.RemovePod(pod)
 		return