-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YUNIKORN-1039] add e2e test which uses volumes #687
Conversation
Please have a look at the lint issue. You can prevent the linter from generating the failure by adding a nolint directive if it is safe. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comments.
Codecov Report
@@ Coverage Diff @@
## master #687 +/- ##
==========================================
+ Coverage 71.87% 71.89% +0.01%
==========================================
Files 51 49 -2
Lines 8079 7956 -123
==========================================
- Hits 5807 5720 -87
+ Misses 2074 2039 -35
+ Partials 198 197 -1 see 19 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error handling, see comments.
Hi @pbacsko thanks for the detailed review and the explanation! I misunderstood it before, and it has been modified now. |
What is this PR for?
This PR adds 2 e2e tests to verify volume binding.
The first case aims to test static volume binding, where a PV and PVC are created before deploying a pod.
The second case checks dynamic volume binding. It creates an NFS provisioner to simulate an NFS storage environment. Pods can use a PVC with a specific storage class, and the provisioner automatically creates the corresponding PV.
What type of PR is it?
Todos
Add more complex cases.
What is the Jira issue?
YUNIKORN-1039
How should this be tested?
Screenshots (if appropriate)
Questions: