Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-1039] add e2e test which uses volumes #687

Closed
wants to merge 4 commits into from

Conversation

targetoee
Copy link
Contributor

What is this PR for?

This PR adds 2 e2e tests to verify volume binding.
The first case aims to test static volume binding, where a PV and PVC are created before deploying a pod.
The second case checks dynamic volume binding. It creates an NFS provisioner to simulate an NFS storage environment. Pods can use a PVC with a specific storage class, and the provisioner automatically creates the corresponding PV.

What type of PR is it?

  • - Test

Todos

Add more complex cases.

What is the Jira issue?

YUNIKORN-1039

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@wilfred-s
Copy link
Contributor

Please have a look at the lint issue. You can prevent the linter from generating the failure by adding a nolint directive if it is safe.

Copy link
Contributor

@pbacsko pbacsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments.

test/e2e/framework/helpers/k8s/pv_conf.go Outdated Show resolved Hide resolved
test/e2e/persistent_volume/persistent_volume_test.go Outdated Show resolved Hide resolved
test/e2e/persistent_volume/persistent_volume_test.go Outdated Show resolved Hide resolved
test/e2e/persistent_volume/persistent_volume_test.go Outdated Show resolved Hide resolved
test/e2e/persistent_volume/persistent_volume_test.go Outdated Show resolved Hide resolved
test/e2e/persistent_volume/persistent_volume_test.go Outdated Show resolved Hide resolved
test/e2e/persistent_volume/persistent_volume_test.go Outdated Show resolved Hide resolved
test/e2e/persistent_volume/persistent_volume_test.go Outdated Show resolved Hide resolved
test/e2e/persistent_volume/persistent_volume_test.go Outdated Show resolved Hide resolved
test/e2e/persistent_volume/persistent_volume_test.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #687 (9b2c542) into master (8b26c37) will increase coverage by 0.01%.
Report is 48 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #687      +/-   ##
==========================================
+ Coverage   71.87%   71.89%   +0.01%     
==========================================
  Files          51       49       -2     
  Lines        8079     7956     -123     
==========================================
- Hits         5807     5720      -87     
+ Misses       2074     2039      -35     
+ Partials      198      197       -1     

see 19 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@wilfred-s wilfred-s requested a review from pbacsko November 2, 2023 08:06
Copy link
Contributor

@pbacsko pbacsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error handling, see comments.

test/e2e/persistent_volume/persistent_volume_test.go Outdated Show resolved Hide resolved
test/e2e/persistent_volume/persistent_volume_test.go Outdated Show resolved Hide resolved
test/e2e/persistent_volume/persistent_volume_test.go Outdated Show resolved Hide resolved
@targetoee
Copy link
Contributor Author

Hi @pbacsko thanks for the detailed review and the explanation! I misunderstood it before, and it has been modified now.

@pbacsko pbacsko closed this in e756d2d Nov 8, 2023
@targetoee targetoee deleted the YUNIKORN-1039 branch November 24, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants