Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2065] Fail logs are not reported correctly in some e2e test #694

Closed
wants to merge 1 commit into from

Conversation

chenyulin0719
Copy link
Contributor

What is this PR for?

The following e2e tests didn’t report detailed logs for the failed spec.

  • user_group_limit
  • preemption
  • simple_preemptor

Move recording action from AfterSuite to AfterEach.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

NA

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2065

How should this be tested?

All existing E2E test should pass.

Screenshots (if appropriate)

Questions:

NA

Copy link
Member

@FrankYang0529 FrankYang0529 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Wait for CI pass. Thank you.

@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Merging #694 (ce06db9) into master (7b08702) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #694   +/-   ##
=======================================
  Coverage   71.81%   71.81%           
=======================================
  Files          51       51           
  Lines        8105     8105           
=======================================
  Hits         5821     5821           
  Misses       2084     2084           
  Partials      200      200           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@FrankYang0529
Copy link
Member

Failed e2e test cases are Verify_Multiple_TaskGroups_Nodes and Test_With_Spark_Jobs. They are not the update in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants