Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2067] Test_With_Spark_Jobs e2e test wait for app state Running after Spark job completed #696

Closed
wants to merge 1 commit into from

Conversation

chenyulin0719
Copy link
Contributor

What is this PR for?

  • Remove the check of Spark application status(Running) in YuniKorn core using RestClient.
  • Instead, use KubeCtl client to varify spark driver pod status(Success).

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

NA

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2067

How should this be tested?

All existing E2E test should pass.

Screenshots (if appropriate)

Questions:

NA

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #696 (908ecae) into master (c7d2c7c) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #696      +/-   ##
==========================================
+ Coverage   71.79%   71.81%   +0.02%     
==========================================
  Files          51       51              
  Lines        8105     8105              
==========================================
+ Hits         5819     5821       +2     
+ Misses       2086     2084       -2     
  Partials      200      200              

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chenyulin0719
Copy link
Contributor Author

The two E2E test fails are from 'gang_scheduling', not from 'spark_job_scheduling'.

Copy link
Member

@FrankYang0529 FrankYang0529 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants