[YUNIKORN-2082] Make autogenerated applicationIDs reproducible #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the admission-controller private function generateAppID() to the shim utils package and renamed to GenerateApplicationID() to allow for re-use by the shim. Updated implementation to use the pod UID instead of a random UUID so that the same identifier will always be created for the same Pod.
craigcondit
requested review from
wilfred-s,
manirajv06,
sunilgovind and
pbacsko
Codecov Report
@@ Coverage Diff @@
## master #707 +/- ##
==========================================
+ Coverage 71.63% 71.64% +0.01%
==========================================
Files 50 50
Lines 7953 7950 -3
==========================================
- Hits 5697 5696 -1
+ Misses 2058 2056 -2
Partials 198 198
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Moved the admission-controller private function generateAppID() to the shim utils package and renamed to GenerateApplicationID() to allow for re-use by the shim. Updated implementation to use the pod UID instead of a random UUID so that the same identifier will always be created for the same Pod.
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2082
How should this be tested?
Updated unit tests.
Screenshots (if appropriate)
Questions: