Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2091] Remove last remnants of Application CRD #710

Closed
wants to merge 1 commit into from

Conversation

craigcondit
Copy link
Contributor

What is this PR for?

Remove last few traces of Application CRD from the shim.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2091

How should this be tested?

N/A - only removes unused code / documentation.

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #710 (9b8bbdb) into master (6a30d08) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #710   +/-   ##
=======================================
  Coverage   71.62%   71.62%           
=======================================
  Files          50       50           
  Lines        7950     7950           
=======================================
  Hits         5694     5694           
  Misses       2058     2058           
  Partials      198      198           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@FrankYang0529 FrankYang0529 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@craigcondit craigcondit deleted the YUNIKORN-2091 branch October 31, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants