Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2096] Update e2e README #714

Closed
wants to merge 2 commits into from

Conversation

doupache
Copy link
Contributor

@doupache doupache commented Oct 31, 2023

What is this PR for?

Add how to run a specified e2e test in the e2e README

What type of PR is it?

  • - Improvement

What is the Jira issue?

YUNIKORN-2096

@doupache
Copy link
Contributor Author

@wusamzong @FrankYang0529 @pbacsko please take a look 🙏

* Launching specified test.
e.g. The first augument of ginkgo.It()

ginkgo.It( "Verify_maxapplications_with_a_specific_group_limit" , ... )
Copy link
Contributor

@chenyulin0719 chenyulin0719 Oct 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

The layout seems broken, would it be better to just use:

  • Launching specified test. e.g. Run test with spec name "Verify_maxapplications_with_a_specific_group_limit"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chenyulin0719 for reviewing. fair point 👍

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #714 (a909f45) into master (b1e44a5) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #714   +/-   ##
=======================================
  Coverage   71.64%   71.64%           
=======================================
  Files          50       50           
  Lines        7950     7950           
=======================================
  Hits         5696     5696           
  Misses       2056     2056           
  Partials      198      198           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@wilfred-s wilfred-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @manirajv06 a second review please

@wilfred-s wilfred-s requested a review from manirajv06 November 2, 2023 07:17
@pbacsko pbacsko self-requested a review November 2, 2023 13:22
Copy link
Contributor

@pbacsko pbacsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM
checked the commands in the console

@pbacsko pbacsko closed this in 1ccc1b1 Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants