-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YUNIKORN-2096] Update e2e README #714
Conversation
@wusamzong @FrankYang0529 @pbacsko please take a look 🙏 |
test/e2e/README.md
Outdated
* Launching specified test. | ||
e.g. The first augument of ginkgo.It() | ||
|
||
ginkgo.It( "Verify_maxapplications_with_a_specific_group_limit" , ... ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @chenyulin0719 for reviewing. fair point 👍
Codecov Report
@@ Coverage Diff @@
## master #714 +/- ##
=======================================
Coverage 71.64% 71.64%
=======================================
Files 50 50
Lines 7950 7950
=======================================
Hits 5696 5696
Misses 2056 2056
Partials 198 198 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @manirajv06 a second review please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 LGTM
checked the commands in the console
What is this PR for?
Add how to run a specified e2e test in the e2e README
What type of PR is it?
What is the Jira issue?
YUNIKORN-2096