-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YUNIKORN-2098] Change go lint SHA detection (following) #715
Conversation
@wilfred-s Please take a look ! This is the following PR of #210 |
I have the same problem in my fork project. |
Pass on my fork with branch doupache:YUNIKORN-2098 https://github.com/doupache/yunikorn-k8shim/actions/runs/6714213847 It seems there is another issue with the Pull Request CI environment |
ca5254e
to
13acfff
Compare
131e340
to
70b3a0b
Compare
In YUNIKORN-285, we previously included git symbolic-ref -q HEAD because Travis CI often encountered a detached head situation. However, now that we have switched to GitHub Actions, we can utilize the checkout@v3 action, which efficiently fetches all Git references. Consequently, we can remove Regarding the modification from @wilfred-s I think this PR is ready for review. |
fetch-depth: 0 | ||
- name: Fetch all branches and tags | ||
run: git fetch --all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not think this is needed, the fetch-depth or any history to build for the e2e tests only.
fetch-depth: 0 | ||
- name: Fetch all branches and tags | ||
run: git fetch --all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not think this is needed, the fetch-depth is a left over of the old pre-split flow and we should not need it here for the code coverage we run.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #715 +/- ##
==========================================
- Coverage 69.52% 69.46% -0.07%
==========================================
Files 50 50
Lines 7993 7993
==========================================
- Hits 5557 5552 -5
- Misses 2248 2252 +4
- Partials 188 189 +1 ☔ View full report in Codecov by Sentry. |
With the cleanup for lint issues we no longer need SHA detection in our lint runs. It was removed as part of an earlier change. |
What is this PR for?
Currently, we will always use the "ORIGIN/HEAD" ref.(In Github Action env) Fallback to "HEAD^" when "ORIGIN/HEAD" doesn't exist.
Also print what git ref the ci have.
I get

fatal: Needed a single revision
on my fork github action ci.https://github.com/doupache/yunikorn-k8shim/actions/runs/6713607756/job/18245448950
CI in the forked repo doesn't seem to have the "ORIGIN/HEAD" ref.
I keep getting the 'fatal: Needed a single revision' error, similar to YUNIKORN-285
What type of PR is it?
What is the Jira issue?
YUNIKORN-2098