[YUNIKORN-2100] Merge functionality of node coordinator into context #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigcondit
requested review from
manirajv06,
wilfred-s,
sunilgovind and
pbacsko
Merge the node_coordinator.go pod event handler logic into the Context's pod event handlers. Also, rename addPodToCache() / updatePodInCache() / removePodFromCache() to addPod() / updatePod() / deletePod() for consistency.
craigcondit
force-pushed
the
YUNIKORN-2100
branch
from
b766c99 to
0c69dc2
Compare
Codecov Report
@@ Coverage Diff @@
## master #716 +/- ##
==========================================
+ Coverage 71.64% 71.99% +0.34%
==========================================
Files 50 49 -1
Lines 7950 7951 +1
==========================================
+ Hits 5696 5724 +28
+ Misses 2056 2031 -25
+ Partials 198 196 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Merge the node_coordinator.go pod event handler logic into the Context's pod event handlers. Also, rename addPodToCache() / updatePodInCache() / removePodFromCache() to addPod() / updatePod() / deletePod() for consistency.
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2100
How should this be tested?
Updated existing tests and added new ones.
Screenshots (if appropriate)
Questions: