[YUNIKORN-2054] Shim: Fix Makefile dependencies #717
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigcondit
requested review from
wilfred-s,
manirajv06,
sunilgovind and
pbacsko
Codecov Report
@@ Coverage Diff @@
## master #717 +/- ##
==========================================
- Coverage 71.64% 71.62% -0.03%
==========================================
Files 50 50
Lines 7950 7950
==========================================
- Hits 5696 5694 -2
- Misses 2056 2058 +2
Partials 198 198 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
wilfred-s
approved these changes
Nov 2, 2023
| @@ -328,7 +328,7 @@ $(DEV_BIN_DIR)/$(PLUGIN_BINARY): go.mod go.sum pkg | |||
| .PHONY: scheduler | |||
| scheduler: $(RELEASE_BIN_DIR)/$(SCHEDULER_BINARY) | |||
|
|
|||
| $(RELEASE_BIN_DIR)/$(SCHEDULER_BINARY): go.mod go.sum pkg | |||
| $(RELEASE_BIN_DIR)/$(SCHEDULER_BINARY): go.mod go.sum $(shell findepkg) | |||
There was a problem hiding this comment.
will fix on commit, no need to update the patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Fix Makefile dependency lists.
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2054
How should this be tested?
Screenshots (if appropriate)
Questions: