-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YUNIKORN-2170] Update Spark version to 3.3.3 #731
Conversation
Spark 3.3.1 has been archived and downloading is slow from archive.apache.org.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #731 +/- ##
=======================================
Coverage 69.46% 69.46%
=======================================
Files 50 50
Lines 7993 7993
=======================================
Hits 5552 5552
Misses 2252 2252
Partials 189 189 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Makefile
Outdated
export SPARK_HOME=$(BASE_DIR)$(TOOLS_DIR)/spark | ||
export SPARK_SUBMIT_CMD=$(SPARK_HOME)/bin/spark-submit | ||
export SPARK_PYTHON_IMAGE=docker.io/apache/spark-py:v$(SPARK_VERSION) | ||
export SPARK_PYTHON_IMAGE=docker.io/apache/spark-py:v3.3.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we not hard code this but have two variables defined and explain that they should be the same minor version at least. Patch versions may differ based on availability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
a97eda8
to
30da8e7
Compare
Spark 3.3.1 has been archived and downloading is slow from archive.apache.org.
What is this PR for?
Update Spark version to 3.3.3 so that it's downloaded faster from mirrors during CI build.
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2170
How should this be tested?
Screenshots (if appropriate)
Questions: