Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2180] Clean up scheduler state initialization #734

Closed
wants to merge 2 commits into from

Address review comments

22990af
Select commit
Loading
Failed to load commit list.
Closed

[YUNIKORN-2180] Clean up scheduler state initialization #734

Address review comments
22990af
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 4, 2024 in 0s

71.27% (+1.75%) compared to 9d303ad

View this Pull Request on Codecov

71.27% (+1.75%) compared to 9d303ad

Details

Codecov Report

Attention: 242 lines in your changes are missing coverage. Please review.

Comparison is base (9d303ad) 69.52% compared to head (22990af) 71.27%.
Report is 2 commits behind head on master.

Files Patch % Lines
pkg/cache/context.go 62.35% 159 Missing and 39 partials ⚠️
pkg/cache/scheduler_callback.go 0.00% 10 Missing ⚠️
pkg/cache/node_events.go 0.00% 8 Missing ⚠️
pkg/cache/task.go 80.95% 6 Missing and 2 partials ⚠️
pkg/shim/scheduler.go 50.00% 4 Missing and 2 partials ⚠️
pkg/dispatcher/dispatcher.go 82.75% 5 Missing ⚠️
pkg/cache/application.go 55.55% 3 Missing and 1 partial ⚠️
pkg/cache/external/scheduler_cache.go 97.58% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #734      +/-   ##
==========================================
+ Coverage   69.52%   71.27%   +1.75%     
==========================================
  Files          50       43       -7     
  Lines        7990     7600     -390     
==========================================
- Hits         5555     5417     -138     
+ Misses       2247     1981     -266     
- Partials      188      202      +14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov