[YUNIKORN-563] test: improve unit test assertion #739
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stu01509
commented
Nov 30, 2023
| assert.Assert(t, result != nil) | ||
| assert.Equal(t, len(result), 1) | ||
| assert.Equal(t, result["a"], "b") | ||
| testCases := []struct { |
There was a problem hiding this comment.
stu01509
commented
Nov 30, 2023
Comment on lines
+143
to
+150
|
|
||
| assert.DeepEqual(t, holder.pod.Labels, map[string]string{ | ||
| "applicationId": "app01", | ||
| "labelKey0": "labelKeyValue0", | ||
| "labelKey1": "labelKeyValue1", | ||
| "placeholder": "true", | ||
| "queue": "root.default", | ||
| }) |
There was a problem hiding this comment.
https://github.com/apache/yunikorn-k8shim/pull/239/files#r592236442
I didn't refactor the holder.pod.Annotations, because it contains yunikorn.apache.org/task-groups has a long value.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #739 +/- ##
==========================================
- Coverage 69.46% 69.43% -0.03%
==========================================
Files 50 50
Lines 7993 7993
==========================================
- Hits 5552 5550 -2
- Misses 2252 2254 +2
Partials 189 189 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Improve unit test assertion
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-563
How should this be tested?
Screenshots (if appropriate)
Questions: