[YUNIKORN-2282] Missing function Stop() in shim SchedulerAPI mock classes #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is already included in #734 which is a much larger refactor that would require a rebase if this PR is merged. Closing for now. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #750 +/- ##
==========================================
+ Coverage 69.49% 69.52% +0.02%
==========================================
Files 50 50
Lines 7990 7990
==========================================
+ Hits 5553 5555 +2
+ Misses 2249 2247 -2
Partials 188 188 ☔ View full report in Codecov by Sentry. |
|
@chenyulin0719 Could you revise the PR to reduce the conflicts? |
|
I'll deal with the conflicts in #734. |
chia7712
approved these changes
Jan 3, 2024
There was a problem hiding this comment.
LGTM
@craigcondit I will merge it tomorrow if you have no more comments. thanks !
|
Many thanks for the help form @chia7712, @craigcondit. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
What type of PR is it?
Todos
NA
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2282
How should this be tested?
Screenshots (if appropriate)
NA
Questions:
NA