[YUNIKORN-2283] Support different compression method zlib for config map #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: PoAn Yang <[email protected]>
FrankYang0529
force-pushed
the
YUNIKORN-2283
branch
from
4e9df80 to
81361e8
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #751 +/- ##
==========================================
+ Coverage 69.49% 69.53% +0.03%
==========================================
Files 50 50
Lines 7990 7999 +9
==========================================
+ Hits 5553 5562 +9
Misses 2249 2249
Partials 188 188 ☔ View full report in Codecov by Sentry. |
|
This is a duplicate issue and we have decided not to implement support for other algorithms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Currently, we only support gzip compression method for config map. We can support other compression methods in golang compress package.
What type of PR is it?
What is the Jira issue?
How should this be tested?
Covered by unit tests.