Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2247] Preemption e2e tests should run in separate namespaces #753

Closed
wants to merge 1 commit into from

Conversation

brandboat
Copy link
Member

What is this PR for?

as title, make Preemption e2e test run in separate namespaces

What type of PR is it?

  • - Improvement

Todos

N/A

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2247

How should this be tested?

covered by existing e2e

Screenshots (if appropriate)

N/A

Questions:

N/A

Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (24c699f) 69.49% compared to head (fad904b) 69.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #753      +/-   ##
==========================================
+ Coverage   69.49%   69.52%   +0.02%     
==========================================
  Files          50       50              
  Lines        7990     7990              
==========================================
+ Hits         5553     5555       +2     
+ Misses       2249     2247       -2     
  Partials      188      188              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pbacsko pbacsko self-requested a review December 26, 2023 13:58
@pbacsko
Copy link
Contributor

pbacsko commented Dec 26, 2023

@brandboat could you look at the failed tests? I don't think they're related, also only 2 suites were affected, but still, something happened.

@brandboat
Copy link
Member Author

@brandboat could you look at the failed tests? I don't think they're related, also only 2 suites were affected, but still, something happened.

Not related, already fired https://issues.apache.org/jira/browse/YUNIKORN-2291
Thanks for poing out that !

Copy link
Contributor

@pbacsko pbacsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants