Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2293] Flaky E2E Test: Failed asserts in LogTestClusterInfoWrapper() blocked the resources cleanup steps #755

Closed
wants to merge 1 commit into from

Conversation

chenyulin0719
Copy link
Contributor

What is this PR for?

Remove the assertions in below logging functions and just purely log the error messages.

  1. LogTestClusterInfoWrapper()
  2. LogYunikornContainer()

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

NA

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2293

How should this be tested?

All the existing test should pass.

make test
make e2e_test

Screenshots (if appropriate)

NA

Questions:

NA

…rapper() blocked the resources cleanup steps
Copy link

codecov bot commented Jan 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (24c699f) 69.49% compared to head (975f0ec) 69.52%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #755      +/-   ##
==========================================
+ Coverage   69.49%   69.52%   +0.02%     
==========================================
  Files          50       50              
  Lines        7990     7990              
==========================================
+ Hits         5553     5555       +2     
+ Misses       2249     2247       -2     
  Partials      188      188              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pbacsko pbacsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

This code will be removed later as soon as we take advantage of upload-artifact action.

@pbacsko pbacsko closed this in a121b13 Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants