Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2290] Add K8s 1.29 to the e2e test matrix #757

Closed
wants to merge 2 commits into from

Conversation

brandboat
Copy link
Member

What is this PR for?

Add K8s 1.29 to the e2e test matrix

What type of PR is it?

  • - Improvement

Todos

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2290

How should this be tested?

AC in my fork brandboat#5

Screenshots (if appropriate)

N/A

Questions:

N/A

@craigcondit
Copy link
Contributor

@brandboat please update scripts/run-e2e-tests.sh as well.

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a121b13) 69.52% compared to head (bcb9af5) 69.49%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #757      +/-   ##
==========================================
- Coverage   69.52%   69.49%   -0.03%     
==========================================
  Files          50       50              
  Lines        7990     7990              
==========================================
- Hits         5555     5553       -2     
- Misses       2247     2249       +2     
  Partials      188      188              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update scripts/run-e2e-tests.sh as well.

@brandboat
Copy link
Member Author

Already addressed comment in the latest comment, thanks

Copy link
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will merge it after QA pass

@chia7712 chia7712 closed this in 5d65dbf Jan 4, 2024
@brandboat brandboat deleted the YUNIKORN-2290 branch January 5, 2024 14:06
chenyulin0719 pushed a commit to chenyulin0719/yunikorn-k8shim that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants