Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [YUNIKORN-1795] Remove the scheduling cycle in the shim #765

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pbacsko
Copy link
Contributor

@pbacsko pbacsko commented Jan 16, 2024

What is this PR for?

The periodic scheduling cycle in the shim is not needed. We can directly forward an incoming task to the core if possible.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-1795

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@pbacsko pbacsko self-assigned this Jan 16, 2024
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (3c78e59) 71.32% compared to head (589af92) 71.84%.

❗ Current head 589af92 differs from pull request most recent head 3ce0776. Consider uploading reports for the commit 3ce0776 to get more accurate results

Files Patch % Lines
pkg/cache/task.go 79.31% 5 Missing and 1 partial ⚠️
pkg/cache/application.go 92.59% 3 Missing and 1 partial ⚠️
pkg/cache/context.go 76.92% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #765      +/-   ##
==========================================
+ Coverage   71.32%   71.84%   +0.52%     
==========================================
  Files          43       43              
  Lines        7592     7626      +34     
==========================================
+ Hits         5415     5479      +64     
+ Misses       1976     1944      -32     
- Partials      201      203       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pbacsko pbacsko marked this pull request as draft January 16, 2024 17:27
@pbacsko pbacsko force-pushed the YUNIKORN-1795 branch 3 times, most recently from 645c839 to 589af92 Compare January 16, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant