Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2338] Build against Kubernetes 1.29.1 #769

Closed
wants to merge 1 commit into from

Conversation

craigcondit
Copy link
Contributor

What is this PR for?

Update build dependencies and implement QueuingHint function to optimize adding requests back to the scheduler queue.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2338

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@craigcondit craigcondit self-assigned this Jan 25, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 61 lines in your changes are missing coverage. Please review.

Comparison is base (27ce47c) 71.32% compared to head (304a724) 70.90%.

Files Patch % Lines
pkg/cache/external/scheduler_cache.go 17.64% 39 Missing and 3 partials ⚠️
pkg/cache/context.go 7.69% 12 Missing ⚠️
pkg/plugin/predicates/predicate_manager.go 82.14% 2 Missing and 3 partials ⚠️
pkg/plugin/support/framework_handle.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #769      +/-   ##
==========================================
- Coverage   71.32%   70.90%   -0.42%     
==========================================
  Files          43       43              
  Lines        7592     7652      +60     
==========================================
+ Hits         5415     5426      +11     
- Misses       1976     2023      +47     
- Partials      201      203       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Update build dependencies and implement QueuingHint function to optimize
adding requests back to the scheduler queue.
@craigcondit craigcondit marked this pull request as ready for review January 25, 2024 20:44
Copy link
Contributor

@pbacsko pbacsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@craigcondit craigcondit deleted the YUNIKORN-2338 branch January 26, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants