Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2394] bump prometheus client to 1.18.0 #782

Closed
wants to merge 1 commit into from

Conversation

FrankYang0529
Copy link
Member

What is this PR for?

The current client in the core is 1.13.1 which is about 18 months old. The current release is 1.18 .

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2394

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (38fae59) 71.13% compared to head (0aa5578) 71.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #782      +/-   ##
==========================================
+ Coverage   71.13%   71.16%   +0.02%     
==========================================
  Files          43       43              
  Lines        7691     7691              
==========================================
+ Hits         5471     5473       +2     
+ Misses       2018     2016       -2     
  Partials      202      202              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chia7712 chia7712 closed this in 458916f Feb 7, 2024
@FrankYang0529 FrankYang0529 deleted the YUNIKORN-2394 branch February 11, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants