[YUNIKORN-2438] Shim: Add license files to Docker images #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add infrastructure to bundle NOTICE/LICENSE and third-party license files. Two new Makefile targets are added: - go-license-check: Check all dependencies for unauthorized licenses - go-license-generate: Retrieve license files for 3rd party components and save to build/third-party-licenses/ directory The generated license files depend on go.mod / go.sum and will be used as input to the Docker image generation.
craigcondit
requested review from
manirajv06,
wilfred-s,
sunilgovind and
pbacsko
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #793 +/- ##
==========================================
+ Coverage 71.55% 71.62% +0.06%
==========================================
Files 43 43
Lines 6332 6332
==========================================
+ Hits 4531 4535 +4
+ Misses 1599 1596 -3
+ Partials 202 201 -1 ☔ View full report in Codecov by Sentry. |
wilfred-s
requested changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Add infrastructure to bundle NOTICE/LICENSE and third-party license files.
Two new Makefile targets are added:
The generated license files depend on go.mod / go.sum and will be used as input to the Docker image generation.
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2438
How should this be tested?
Screenshots (if appropriate)
Questions: