Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2549] Fixing lint issues #816

Closed
wants to merge 1 commit into from

Conversation

makinyemi
Copy link
Contributor

What is this PR for?

Fixing lint issues
Replaced strings Replace() with ReplaceAll() to resolve gocritic issue.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2549

How should this be tested?

N/A

Screenshots (if appropriate)

N/A

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

Replaced strings Replace() with ReplaceAll() to resolve gocritic issue.
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.15%. Comparing base (e65642e) to head (e10f1ca).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #816   +/-   ##
=======================================
  Coverage   66.15%   66.15%           
=======================================
  Files          69       69           
  Lines        7517     7517           
=======================================
  Hits         4973     4973           
  Misses       2333     2333           
  Partials      211      211           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pbacsko pbacsko self-requested a review April 12, 2024 09:44
Copy link
Contributor

@pbacsko pbacsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@pbacsko pbacsko closed this in bda57dd Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants