[YUNIKORN-2575] Clarify error returned by IsPodFitNode #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsPodFitNode should clearly set the error if the pod or node is missing from the cache when run. The result, if it is an error, contains the predicate plugin name that failed to improve identification in the events.
wilfred-s
requested review from
brandboat,
chia7712,
zhuqi-lucas and
craigcondit
craigcondit
approved these changes
Apr 23, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #824 +/- ##
==========================================
- Coverage 66.13% 66.05% -0.08%
==========================================
Files 69 69
Lines 7517 7523 +6
==========================================
- Hits 4971 4969 -2
- Misses 2334 2342 +8
Partials 212 212 ☔ View full report in Codecov by Sentry. |
chia7712
reviewed
Apr 23, 2024
Logged YUNIKORN-2578 for that as I noticed the same. Also logged YUNIKORN-2577 to clean up the IsPodFitNodeViaPreemption function |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
IsPodFitNode should clearly set the error if the pod or node is missing from the cache when run. The result, if it is an error, contains the predicate plugin name that failed to improve identification in the events.
What type of PR is it?
What is the Jira issue?
How should this be tested?
NA, no behaviour change just cleanup of return values