Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2601] Update kindest/node: v1.29.1 to v1.29.2, v1.28.6 to v1.28.7, v1.27.10 to v1.27.11, v1.26.13 -> v1.26.14 #833

Closed
wants to merge 3 commits into from

Conversation

ryankert01
Copy link
Contributor

What is this PR for?

as title.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

N/A

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2601

How should this be tested?

github ci

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master@d884f19). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #833   +/-   ##
=========================================
  Coverage          ?   66.01%           
=========================================
  Files             ?       69           
  Lines             ?     7541           
  Branches          ?        0           
=========================================
  Hits              ?     4978           
  Misses            ?     2351           
  Partials          ?      212           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@wilfred-s wilfred-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chia7712
Copy link
Member

chia7712 commented May 9, 2024

@ryankert01 Could you please update makefile also?

K8S_VERSION := v1.29.1

@wilfred-s wilfred-s closed this in b7499e1 May 9, 2024
@chia7712
Copy link
Member

chia7712 commented May 9, 2024

@ryankert01 Could you please update makefile also?

I file a follow-up https://issues.apache.org/jira/browse/YUNIKORN-2617

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants