[YUNIKORN-2578] Refactor SchedulerCache.GetPod() remove bool return #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #837 +/- ##
==========================================
- Coverage 66.06% 66.02% -0.05%
==========================================
Files 69 69
Lines 7547 7549 +2
==========================================
- Hits 4986 4984 -2
- Misses 2348 2352 +4
Partials 213 213 ☔ View full report in Codecov by Sentry. |
pbacsko
requested review from
pbacsko,
craigcondit and
wilfred-s
and removed request for
craigcondit
chia7712
reviewed
May 13, 2024
There was a problem hiding this comment.
@ryankert01 thanks for this refactor. one small suggestion is left. PTAL
| @@ -645,8 +645,7 @@ func (ctx *Context) IsPodFitNode(name, node string, allocate bool) error { | |||
| ctx.lock.RLock() | |||
| defer ctx.lock.RUnlock() | |||
| var pod *v1.Pod | |||
| var ok bool | |||
| if pod, ok = ctx.schedulerCache.GetPod(name); !ok { | |||
There was a problem hiding this comment.
pod := ctx.schedulerCache.GetPod(name)
if pod == nil {
return ErrorPodNotFound
}
chia7712
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
SchedulerCache GetPod() and GetPodNoLock() retrun two values:
The boolean value is redundant as it is false if the pod is not found and a nil is returned for the pod. The boolean is true if the pod has a value. Testing for a nil pod has the same result.
We do not cache a nil pod in the cache for a pod UID
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2578
How should this be tested?
make test
github ci
Screenshots (if appropriate)
Questions: