Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2616] Remove unused bool return from PreemptionPredicates() #841

Closed
wants to merge 2 commits into from

Conversation

ryankert01
Copy link
Contributor

What is this PR for?

The predicate manager method PreemptionPredicates() returns two values an int and boolean. The boolean is false if the integer is -1 and true for 0 or llarger. There is no need for the boolean as the -1 already indicates the same

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2616

How should this be tested?

Github CI

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 67.34%. Comparing base (0c90ea5) to head (c0d964e).
Report is 1 commits behind head on master.

Files Patch % Lines
pkg/plugin/predicates/predicate_manager.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #841   +/-   ##
=======================================
  Coverage   67.34%   67.34%           
=======================================
  Files          70       70           
  Lines        7598     7598           
=======================================
  Hits         5117     5117           
  Misses       2269     2269           
  Partials      212      212           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@chenyulin0719 chenyulin0719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes.

pkg/plugin/predicates/predicate_manager_test.go Outdated Show resolved Hide resolved
pkg/plugin/predicates/predicate_manager_test.go Outdated Show resolved Hide resolved
@chenyulin0719 chenyulin0719 requested a review from chia7712 May 16, 2024 17:20
@ryankert01 ryankert01 requested a review from chenyulin0719 May 17, 2024 13:12
Copy link
Contributor

@chenyulin0719 chenyulin0719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

Copy link
Contributor

@pbacsko pbacsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@chia7712 chia7712 closed this in 6f2800f May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants